From 01f5ff46d222ee137a87a69cae430421e50c21b5 Mon Sep 17 00:00:00 2001 From: Keuin Date: Thu, 14 Apr 2022 13:43:28 +0800 Subject: Use flexible intermediate color depth when rendering. Note: further debugging is needed. The output image quality won't be improved when using 16bit/32bit internal color depth. --- bitmap.h | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) (limited to 'bitmap.h') diff --git a/bitmap.h b/bitmap.h index b35bf81..a5b05e6 100644 --- a/bitmap.h +++ b/bitmap.h @@ -136,11 +136,25 @@ public: width(width), height(height), content{data} {} static bitmap average(const std::vector> &images) { + using Acc = typename std::conditional< + (sizeof(T) <= 1), + uint_fast16_t, + typename std::conditional< + (sizeof(T) <= 2), + uint_fast32_t, + typename std::conditional< + (sizeof(T) <= 4), + uint_fast64_t, + uintmax_t + >::type + >::type + >::type; // pick the smallest suitable type for accumulator + static_assert(sizeof(Acc) > sizeof(T), "accumulator may overflow"); assert(!images.empty()); bitmap result{images[0].width, images[0].height}; const auto m = images.size(); const auto n = images[0].content.size(); - uint_fast32_t acc_r, acc_g, acc_b; + Acc acc_r, acc_g, acc_b; for (size_t i = 0; i < n; ++i) { acc_r = 0; acc_g = 0; @@ -197,7 +211,6 @@ public: bitmap out{shape.first, shape.second}; for (size_t i = 0; i < sz; ++i) { out[i] = pixel::from(src[i]); - std::cerr << (int) out[i].r << ' ' << (int) out[i].g << ' ' << (int) out[i].b << std::endl; } return out; } -- cgit v1.2.3