From 011ac22afbffe80de478451f812c0853e8153af3 Mon Sep 17 00:00:00 2001 From: Keuin Date: Sat, 23 Jan 2021 15:55:39 +0800 Subject: I decided to change the version to `1.5.0` in order to stress the non forward-compatible for 1.4.6 created backups in older versions (<=1.4.5). --- gradle.properties | 2 +- .../kbackupfabric/backup/name/IncrementalBackupFileNameEncoder.java | 1 + .../keuin/kbackupfabric/util/backup/incremental/ObjectCollection.java | 2 ++ 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/gradle.properties b/gradle.properties index 8b22d27..5ef3cf0 100644 --- a/gradle.properties +++ b/gradle.properties @@ -6,7 +6,7 @@ minecraft_version=1.14.4 yarn_mappings=1.14.4+build.18 loader_version=0.11.0 # Mod Properties -mod_version=1.4.6 +mod_version=1.5.0 maven_group=com.keuin.kbackupfabric archives_base_name=kbackup-fabric # Dependencies diff --git a/src/main/java/com/keuin/kbackupfabric/backup/name/IncrementalBackupFileNameEncoder.java b/src/main/java/com/keuin/kbackupfabric/backup/name/IncrementalBackupFileNameEncoder.java index 8910d7f..77e19b9 100644 --- a/src/main/java/com/keuin/kbackupfabric/backup/name/IncrementalBackupFileNameEncoder.java +++ b/src/main/java/com/keuin/kbackupfabric/backup/name/IncrementalBackupFileNameEncoder.java @@ -7,6 +7,7 @@ import java.util.regex.Pattern; public class IncrementalBackupFileNameEncoder implements BackupFileNameEncoder { private static final String backupFileNamePrefix = "incremental"; + // TODO: Merge all date formatter like this, into one single instance private static final DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd_HH-mm-ss"); // TODO: make this private and use singleton pattern diff --git a/src/main/java/com/keuin/kbackupfabric/util/backup/incremental/ObjectCollection.java b/src/main/java/com/keuin/kbackupfabric/util/backup/incremental/ObjectCollection.java index d36ff59..0cd36a0 100644 --- a/src/main/java/com/keuin/kbackupfabric/util/backup/incremental/ObjectCollection.java +++ b/src/main/java/com/keuin/kbackupfabric/util/backup/incremental/ObjectCollection.java @@ -7,6 +7,8 @@ import java.util.*; * This class must be in package `com.keuin.kbackupfabric.util.backup.incremental.ObjectCollection`, * or it will not be compatible with old backups. * It remains only to keep a backward compatibility, and should be converted to `ObjectCollection2` as soon as possible. + * Thus, this class is marked as `Depreciated`. However, it should not be removed since it is needed to read legacy + * backups correctly. But new codes should not use this class any more. */ @Deprecated public class ObjectCollection implements Serializable { -- cgit v1.2.3